Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.22] Add K8s version arg to secondary control plane nodes in node upgrader #9320

Merged

Conversation

eks-distro-pr-bot
Copy link
Contributor

This is an automated cherry-pick of #9319

/assign 2ez4szliu

From K8s 1.32 node upgrader scheduled in secondary control plane nodes
will need the K8s version to add some version specific flags.

Signed-off-by: Rahul Ganesh <[email protected]>
@eks-distro-bot
Copy link
Collaborator

Hi @eks-distro-pr-bot. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-0.22@c176e0a). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-0.22    #9320   +/-   ##
===============================================
  Coverage                ?   72.40%           
===============================================
  Files                   ?      589           
  Lines                   ?    46363           
  Branches                ?        0           
===============================================
  Hits                    ?    33571           
  Misses                  ?    11032           
  Partials                ?     1760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2ez4szliu
Copy link
Member

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2ez4szliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@2ez4szliu
Copy link
Member

/override eks-anywhere-e2e-presubmit

@eks-distro-bot
Copy link
Collaborator

@2ez4szliu: Overrode contexts on behalf of 2ez4szliu: eks-anywhere-e2e-presubmit

In response to this:

/override eks-anywhere-e2e-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@2ez4szliu
Copy link
Member

/ok-to-test

@2ez4szliu 2ez4szliu merged commit 8b37c0f into aws:release-0.22 Feb 26, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants